gluster-block.git/rpc, branch v0.3

delete/rollback: check for matching gbid before deleting a block

2017-10-09T05:43:20+00:00

Currently we are just checking for blockname in targetcli list output, if it
exist we will delete the backend.

We do not check if block belongs to a given volume (say vol1), because of which
a rollback on a failure to create block with same name, on same node but on a
different volume (say vol2) deletes block backend belonging to vol1.

Solution:
only if blockname + gbid matches continue delete.

Change-Id: I396c228dad3cf4f51cc6676a266b837bdf6040c7
Signed-off-by: Prasanna Kumar Kalever

socket: switch to MT-safe get host addr info

2017-09-19T05:50:32+00:00

This was fixed in an attempt to clean the sockfd leaks

Change-Id: Icd82635134050c83167a48b451b347f5c2b9bf39
Signed-off-by: Prasanna Kumar Kalever 
Signed-off-by: Pranith Kumar K

rpc: switch to MT-safe block RPC routines

2017-09-19T04:07:48+00:00

blockResponse *
block_delete_1(blockDelete *argp, CLIENT *clnt)
{
        static blockResponse clnt_res; <<<<<<-------- Same memory is used by everyone

        memset((char *)&clnt_res, 0, sizeof(clnt_res)); <<<<<---- Here memset is happening
        if (clnt_call (clnt, BLOCK_DELETE,
                (xdrproc_t) xdr_blockDelete, (caddr_t) argp,
                (xdrproc_t) xdr_blockResponse, (caddr_t) &clnt_res,
                TIMEOUT) != RPC_SUCCESS) {
                return (NULL);
        }
        return (&clnt_res); <<<<<---- ptr to this memory is returned.
}

So while Thread-1 is returned "return (&clnt_res);" another thread could be
doing "memset((char *)&clnt_res, 0, sizeof(clnt_res));"

This seem to be a day-1 gluster-blockd bug from the looks of it.

Change-Id: I3fc76d7814c4fe5b286577586ec44d752dcc73f0
Signed-off-by: Prasanna Kumar Kalever 
Signed-off-by: Pranith Kumar K

misc: fix warnings

2017-08-29T17:30:13+00:00

Change-Id: I11274ad59925ec3d034baefc2cc2e307afa45479
Signed-off-by: Prasanna Kumar Kalever

gluster-block: parse remote command outputs

2017-08-28T15:26:04+00:00

Change-Id: Ic2317843a8bd882fc26233373a4b4c35b13f24c6
Signed-off-by: Prasanna Kumar Kalever

gluster-block: use targetcli interactive mode

2017-08-28T09:36:00+00:00

Currently, on each targetcli create call, rtslib will rebuild its bs_cache, so
as the /sys/kernel/config/target/core dir gets more entries this takes longer
and longer to scan. Hence using repetitive targetcli in the block create
for creating iqn, backend, setting acls, setting globals will induce too
much delay in block create. As the number of blocks on the node increases,
the delay will be too longer.

This does not happen if we open targetcli in interactive mode and just do
multiple create commands form it, since the bs_cache is build once.

Read More:
https://goo.gl/8aYT38

Change-Id: I2be78a748e013f253ce8f99746989a1cf735a56f
Signed-off-by: Prasanna Kumar Kalever

logger: support logdir choosing via Environment variable

2017-08-17T08:52:55+00:00

Currently the default logdir is DATADIR /log/gluster-block/

This patch will provide a way to change this default logdir via Env variable
$ export GB_LOGDIR=/var/log/gluster-block-new-path/

Note: make sure to restart the processes (cli & daemon) after you set GB_LOGDIR

Change-Id: Id142e4a4dfe7b6ebc9cf8296b8ceb8bff37691b8
Signed-off-by: Prasanna Kumar Kalever

gluster-block: support force delete option

2017-08-08T10:14:32+00:00

$ gluster-block help
gluster-block (0.2.1)
usage:
  gluster-block   [] [--json*]

commands:
[...]
  delete   [force]
        delete block device.
[...]

Change-Id: I64ac01ec148e2e1d4d0ba0d4c5560df9334d58f5
Signed-off-by: Prasanna Kumar Kalever

gluster-block: do not allow delete if any node is down

2017-08-03T12:46:05+00:00

Change-Id: If729b80a8139add989170d3b590e92706128c37e
Signed-off-by: Prasanna Kumar Kalever

create: move saveconfig out of the loop

2017-07-12T19:01:54+00:00

In the previous patch,

`commit f2e46779c0175e5063ce07256023f1977b333f2d
  Author: Prasanna Kumar Kalever 
  Date:   Fri Jul 7 15:51:38 2017 +0530

  tcmu: backstore attribute set cmd_time_out=0
  [...]`

unintentionally saveconfig was left inside the loop. Hence fixing this by
pushing it outside.

Problem:
Currently, while populating 'exec' variable the following line after saveconfig
i.e. at line GB_FREE(tmp); the 'tmp' variable is made NULL; Hence in each
loop, condition if(!tmp) is always true, and the 'else' set of statements will
never be executed.

Impact:
On block create with HA > 1, only for Nth(last) node portal gets created for
rest of the nodes portal and their attr will never be created/set. As a
result block is not exported correctly.

Also, remove duplicated DEVNULLPATH redirection with attr setting

Change-Id: I1f77461de6b89af4e4af098e0444ea3526669030
Signed-off-by: Prasanna Kumar Kalever