gluster-block.git/rpc, branch master fix spec file 2018-03-06T10:12:26+00:00 Prasanna Kumar Kalever prasanna.kalever@redhat.com 2018-03-06T09:55:07+00:00 8b106204f52b283cdbe7a128c14f851dd54a150c also other minor compiler errors Change-Id: I17625008d91740f3ba9efc6e574ec3dcd0b6c85f Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com> 
also other minor compiler errors

Change-Id: I17625008d91740f3ba9efc6e574ec3dcd0b6c85f
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
info: show failed nodes 2018-03-05T09:43:30+00:00 Prasanna Kumar Kalever prasanna.kalever@redhat.com 2018-03-05T07:01:00+00:00 305e1c5ffead749fd6ea555b52e46d9e64c9bd55 $ cat /mnt/block-meta/block VOLUME: sample GBID: 9d278e06-b2d1-4050-bd92-c8e8b40a5654 HA: 3 ENTRYCREATE: INPROGRESS SIZE: 9663676416 ENTRYCREATE: SUCCESS 192.168.0.104: CONFIGSUCCESS 192.168.0.105: CONFIGFAIL 192.168.0.106: CLEANUPFAIL $ gluster-block info sample/block NAME: block VOLUME: sample GBID: 9d278e06-b2d1-4050-bd92-c8e8b40a5654 SIZE: 9.0 GiB HA: 3 PASSWORD: EXPORTED ON: 192.168.0.104 ENCOUNTERED FAILURES ON: 192.168.0.105 192.168.0.106 $ gluster-block info sample/block --json-pretty { "NAME":"block", "VOLUME":"sample", "GBID":"9d278e06-b2d1-4050-bd92-c8e8b40a5654", "SIZE":"9.0 GiB", "HA":3, "PASSWORD":"", "EXPORTED ON":[ "192.168.0.104" ], "ENCOUNTERED FAILURES ON":[ "192.168.0.105", "192.168.0.106" ] } Change-Id: I3d47e75f64719b9eeab661006bf4ccaa629a8408 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com> 
$ cat /mnt/block-meta/block
VOLUME: sample
GBID: 9d278e06-b2d1-4050-bd92-c8e8b40a5654
HA: 3
ENTRYCREATE: INPROGRESS
SIZE: 9663676416
ENTRYCREATE: SUCCESS
192.168.0.104: CONFIGSUCCESS
192.168.0.105: CONFIGFAIL
192.168.0.106: CLEANUPFAIL

$ gluster-block info sample/block
NAME: block
VOLUME: sample
GBID: 9d278e06-b2d1-4050-bd92-c8e8b40a5654
SIZE: 9.0 GiB
HA: 3
PASSWORD:
EXPORTED ON: 192.168.0.104
ENCOUNTERED FAILURES ON: 192.168.0.105 192.168.0.106

$ gluster-block info sample/block --json-pretty
{
  "NAME":"block",
  "VOLUME":"sample",
  "GBID":"9d278e06-b2d1-4050-bd92-c8e8b40a5654",
  "SIZE":"9.0 GiB",
  "HA":3,
  "PASSWORD":"",
  "EXPORTED ON":[
    "192.168.0.104"
  ],
  "ENCOUNTERED FAILURES ON":[
    "192.168.0.105",
    "192.168.0.106"
  ]
}

Change-Id: I3d47e75f64719b9eeab661006bf4ccaa629a8408
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
create: split "ROLLBACK ON:" to SUCCESS and FAILURE 2018-03-05T09:40:27+00:00 Prasanna Kumar Kalever prasanna.kalever@redhat.com 2017-08-29T10:40:36+00:00 2c44d5d25adba74f6aa3553bfa33d2909490fde1 Ex: When 192.168.124.179 goes while create is in progress, $ gluster-block create sample/1 ha 3 192.168.124.208,192.168.124.8,\ 192.168.124.179 1GiB --json-pretty; { "IQN":"iqn.2016-12.org.gluster-block:451cfb72-bf63-45ce-83d9-d059c010cbdd", "PORTAL(S)":[ "192.168.124.208:3260", "192.168.124.8:3260", "192.168.124.179:3260" ], "ROLLBACK FAILED ON":[ "192.168.124.179" ], "ROLLBACK SUCCESS ON":[ "192.168.124.8", "192.168.124.208" ], "RESULT":"FAIL" } Change-Id: Ibb947304154055f7477b80f1850184fb1965416d Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com> 
Ex: When 192.168.124.179 goes while create is in progress,

$ gluster-block create sample/1 ha 3 192.168.124.208,192.168.124.8,\
                                     192.168.124.179 1GiB --json-pretty;
{
  "IQN":"iqn.2016-12.org.gluster-block:451cfb72-bf63-45ce-83d9-d059c010cbdd",
  "PORTAL(S)":[
    "192.168.124.208:3260",
    "192.168.124.8:3260",
    "192.168.124.179:3260"
  ],
  "ROLLBACK FAILED ON":[
    "192.168.124.179"
  ],
  "ROLLBACK SUCCESS ON":[
    "192.168.124.8",
    "192.168.124.208"
  ],
  "RESULT":"FAIL"
}

Change-Id: Ibb947304154055f7477b80f1850184fb1965416d
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
delete: support [unlink-storage <yes|no>] option 2018-02-08T07:41:56+00:00 Prasanna Kumar Kalever prasanna.kalever@redhat.com 2017-11-29T12:14:50+00:00 7008073e1d00c1af0dc5913cdf5d94372f10088d $ gluster-block help gluster-block (0.3) usage: gluster-block <command> <volname[/blockname]> [<args>] [--json*] commands: [...] delete <volname/blockname> [unlink-storage <yes|no>] [force] delete block device. [...] supported JSON formats: --json|--json-plain|--json-spaced|--json-pretty Change-Id: I64bc99a8519be6f90a7e8bc5558b0d7518661995 Fixes: #19 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com> 
$ gluster-block help
gluster-block (0.3)
usage:
  gluster-block <command> <volname[/blockname]> [<args>] [--json*]

commands:
[...]

  delete  <volname/blockname> [unlink-storage <yes|no>] [force]
        delete block device.
[...]
supported JSON formats:
  --json|--json-plain|--json-spaced|--json-pretty

Change-Id: I64bc99a8519be6f90a7e8bc5558b0d7518661995
Fixes: #19
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
create: support [storage <filename>] option 2018-02-08T07:41:40+00:00 Prasanna Kumar Kalever prasanna.kalever@redhat.com 2018-02-07T16:10:13+00:00 450f7e89116ed104f092dd1a709c0f057150a4f7 $ gluster-block help gluster-block (0.3) usage: gluster-block <command> <volname[/blockname]> [<args>] [--json*] commands: create <volname/blockname> [ha <count>] [auth <enable|disable>] [prealloc <full|no>] [storage <filename>] <host1[,host2,...]> <size> create block device [defaults: ha 1, auth disable, prealloc no, size in bytes] [...] supported JSON formats: --json|--json-plain|--json-spaced|--json-pretty Fixes: #18 Change-Id: I5d9b4abb58596bd2297cffb294c6d31f752d53e9 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com> 
$ gluster-block help
gluster-block (0.3)
usage:
  gluster-block <command> <volname[/blockname]> [<args>] [--json*]

commands:
  create  <volname/blockname> [ha <count>]
                              [auth <enable|disable>]
                              [prealloc <full|no>]
                              [storage <filename>]
                              <host1[,host2,...]> <size>
        create block device [defaults: ha 1, auth disable, prealloc no, size in bytes]
[...]
supported JSON formats:
  --json|--json-plain|--json-spaced|--json-pretty

Fixes: #18
Change-Id: I5d9b4abb58596bd2297cffb294c6d31f752d53e9
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
replace strcat and strcpy with their secure versions 2018-02-08T07:00:49+00:00 Prasanna Kumar Kalever prasanna.kalever@redhat.com 2018-01-29T11:32:07+00:00 d7ebb697457fc4b8562bb1475a6832f1badb15f8 Change-Id: If98ce7b7e50901ee130bbe190a12664ec0adb8c2 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com> 
Change-Id: If98ce7b7e50901ee130bbe190a12664ec0adb8c2
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
replace: add replace feature 2018-02-07T11:19:21+00:00 Prasanna Kumar Kalever prasanna.kalever@redhat.com 2018-02-05T09:37:26+00:00 540e81676b1011dcf85fbe5cd6739a4f2143b2ab 1. create conf in new node 2. delete conf from old node 3. replace portals from nodes hosting other paths (HA) $ gluster-block create sample/block ha 3 192.168.124.57,192.168.124.26,192.168.124.30 1GiB --json-pretty { "IQN":"iqn.2016-12.org.gluster-block:d516bb5c-5f56-4d9c-96a7-385df19c2e2c", "PORTAL(S)":[ "192.168.124.57:3260", "192.168.124.26:3260", "192.168.124.30:3260" ], "RESULT":"SUCCESS" } $ gluster-block help gluster-block (0.3) usage: gluster-block <command> <volname[/blockname]> [<args>] [--json*] commands: [...] replace <volname/blockname> <old-node> <new-node> [force] replace operations. [...] supported JSON formats: --json|--json-plain|--json-spaced|--json-pretty $ gluster-block replace sample/block 192.168.124.26 192.168.124.56 --json-pretty { "NAME":"block", "CREATE SUCCESS":"192.168.124.56", "DELETE SUCCESS":"192.168.124.26", "REPLACE PORTAL SUCCESS ON":[ "192.168.124.57", "192.168.124.30" ], "RESULT":"SUCCESS" } Fixes: #4 Change-Id: I0411d15c407111db0d423052d9a6bc075174bf90 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com> 
1. create conf in new node
2. delete conf from old node
3. replace portals from nodes hosting other paths (HA)

$ gluster-block create sample/block ha 3 192.168.124.57,192.168.124.26,192.168.124.30 1GiB --json-pretty
{
  "IQN":"iqn.2016-12.org.gluster-block:d516bb5c-5f56-4d9c-96a7-385df19c2e2c",
  "PORTAL(S)":[
    "192.168.124.57:3260",
    "192.168.124.26:3260",
    "192.168.124.30:3260"
  ],
  "RESULT":"SUCCESS"
}

$ gluster-block help
gluster-block (0.3)
usage:
  gluster-block <command> <volname[/blockname]> [<args>] [--json*]

commands:
[...]
  replace <volname/blockname> <old-node> <new-node> [force]
        replace operations.
[...]

supported JSON formats:
  --json|--json-plain|--json-spaced|--json-pretty

$ gluster-block replace sample/block 192.168.124.26 192.168.124.56 --json-pretty
{
  "NAME":"block",
  "CREATE SUCCESS":"192.168.124.56",
  "DELETE SUCCESS":"192.168.124.26",
  "REPLACE PORTAL SUCCESS ON":[
    "192.168.124.57",
    "192.168.124.30"
  ],
  "RESULT":"SUCCESS"
}

Fixes: #4
Change-Id: I0411d15c407111db0d423052d9a6bc075174bf90
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
versioning: add capabilities support 2018-01-18T10:11:39+00:00 Prasanna Kumar Kalever prasanna.kalever@redhat.com 2018-01-10T18:18:38+00:00 46f460fa669ce9f7b9f2de9e54cefc3726dcd029 Change-Id: Ic63f7c9fa169ee37b796093554c59016fbbfaa46 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com> 
Change-Id: Ic63f7c9fa169ee37b796093554c59016fbbfaa46
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
delete/rollback: check for matching gbid before deleting a block 2017-10-09T05:43:20+00:00 Prasanna Kumar Kalever prasanna.kalever@redhat.com 2017-08-03T09:05:37+00:00 e6ed5b53cf33b4315ee2846a9f773cd672a5de8c Currently we are just checking for blockname in targetcli list output, if it exist we will delete the backend. We do not check if block belongs to a given volume (say vol1), because of which a rollback on a failure to create block with same name, on same node but on a different volume (say vol2) deletes block backend belonging to vol1. Solution: only if blockname + gbid matches continue delete. Change-Id: I396c228dad3cf4f51cc6676a266b837bdf6040c7 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com> 
Currently we are just checking for blockname in targetcli list output, if it
exist we will delete the backend.

We do not check if block belongs to a given volume (say vol1), because of which
a rollback on a failure to create block with same name, on same node but on a
different volume (say vol2) deletes block backend belonging to vol1.

Solution:
only if blockname + gbid matches continue delete.

Change-Id: I396c228dad3cf4f51cc6676a266b837bdf6040c7
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
socket: switch to MT-safe get host addr info 2017-09-19T05:50:32+00:00 Prasanna Kumar Kalever prasanna.kalever@redhat.com 2017-09-19T03:13:43+00:00 149c72ca069fd5c1fb8960607d7443536995d235 This was fixed in an attempt to clean the sockfd leaks Change-Id: Icd82635134050c83167a48b451b347f5c2b9bf39 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com> Signed-off-by: Pranith Kumar K <pkarampu@redhat.com> 
This was fixed in an attempt to clean the sockfd leaks

Change-Id: Icd82635134050c83167a48b451b347f5c2b9bf39
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>